From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] netdev: remove useless codes of tun_automq_select_queue Date: Mon, 08 Oct 2018 10:27:27 -0700 (PDT) Message-ID: <20181008.102727.220761622269585721.davem@davemloft.net> References: <20181008085112.56290-1-wangli39@baidu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: wangli39@baidu.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:56988 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbeJIAkN (ORCPT ); Mon, 8 Oct 2018 20:40:13 -0400 In-Reply-To: <20181008085112.56290-1-wangli39@baidu.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Wang Li Date: Mon, 8 Oct 2018 16:51:12 +0800 > @@ -1045,15 +1039,12 @@ static void tun_automq_xmit(struct tun_struct *tun, struct sk_buff *skb) > * RPS hash and save it into the flow_table here. > */ > __u32 rxhash; > + struct tun_flow_entry *e; Please always order local variable declarations from longest to shortest line. Thank you.