From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH V1 net 2/5] net: ena: fix warning in rmmod caused by double iounmap Date: Mon, 08 Oct 2018 10:56:53 -0700 (PDT) Message-ID: <20181008.105653.2116602743772544221.davem@davemloft.net> References: <1539001724-25980-1-git-send-email-akiyano@amazon.com> <1539001724-25980-3-git-send-email-akiyano@amazon.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dwmw@amazon.com, zorik@amazon.com, matua@amazon.com, saeedb@amazon.com, msw@amazon.com, aliguori@amazon.com, nafea@amazon.com, gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com To: akiyano@amazon.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57422 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726458AbeJIBJq (ORCPT ); Mon, 8 Oct 2018 21:09:46 -0400 In-Reply-To: <1539001724-25980-3-git-send-email-akiyano@amazon.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Date: Mon, 8 Oct 2018 15:28:41 +0300 > From: Arthur Kiyanovski > > Memory mapped with devm_ioremap is automatically freed when the driver > is disconnected from the device. Therefore there is no need to > explicitly call devm_iounmap. > > Signed-off-by: Arthur Kiyanovski > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c > index 25621a2..23f2dda 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c > @@ -3099,15 +3099,7 @@ static int ena_rss_init_default(struct ena_adapter *adapter) > > static void ena_release_bars(struct ena_com_dev *ena_dev, struct pci_dev *pdev) > { > - int release_bars; > - > - if (ena_dev->mem_bar) > - devm_iounmap(&pdev->dev, ena_dev->mem_bar); > - > - if (ena_dev->reg_bar) > - devm_iounmap(&pdev->dev, ena_dev->reg_bar); > - > - release_bars = pci_select_bars(pdev, IORESOURCE_MEM) & ENA_BAR_MASK; > + int release_bars = pci_select_bars(pdev, IORESOURCE_MEM) & ENA_BAR_MASK; > pci_release_selected_regions(pdev, release_bars); Always have an empty line between local variable declarations and actual function code.