netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: christian@brauner.io, jbenc@redhat.com,
	stephen@networkplumber.org, David Ahern <dsahern@gmail.com>
Subject: [PATCH v2 net-next 02/23] netlink: Add extack message to nlmsg_parse for invalid header length
Date: Sun,  7 Oct 2018 20:16:23 -0700	[thread overview]
Message-ID: <20181008031644.15989-3-dsahern@kernel.org> (raw)
In-Reply-To: <20181008031644.15989-1-dsahern@kernel.org>

From: David Ahern <dsahern@gmail.com>

Give a user a reason why EINVAL is returned in nlmsg_parse.

Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Christian Brauner <christian@brauner.io>
---
 include/net/netlink.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/net/netlink.h b/include/net/netlink.h
index 589683091f16..9522a0bf1f3a 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -516,8 +516,10 @@ static inline int nlmsg_parse(const struct nlmsghdr *nlh, int hdrlen,
 			      const struct nla_policy *policy,
 			      struct netlink_ext_ack *extack)
 {
-	if (nlh->nlmsg_len < nlmsg_msg_size(hdrlen))
+	if (nlh->nlmsg_len < nlmsg_msg_size(hdrlen)) {
+		NL_SET_ERR_MSG(extack, "Invalid header length");
 		return -EINVAL;
+	}
 
 	return nla_parse(tb, maxtype, nlmsg_attrdata(nlh, hdrlen),
 			 nlmsg_attrlen(nlh, hdrlen), policy, extack);
-- 
2.11.0

  parent reply	other threads:[~2018-10-08 10:26 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  3:16 [PATCH v2 net-next 00/23] rtnetlink: Add support for rigid checking of data in dump request David Ahern
2018-10-08  3:16 ` [PATCH v2 net-next 01/23] netlink: Pass extack to dump handlers David Ahern
2018-10-08  3:16 ` David Ahern [this message]
2018-10-08  3:16 ` [PATCH v2 net-next 03/23] net: Add extack to nlmsg_parse David Ahern
2018-10-08  3:16 ` [PATCH v2 net-next 04/23] netlink: Add strict version of nlmsg_parse and nla_parse David Ahern
2018-10-08  9:52   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 05/23] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs David Ahern
2018-10-08  3:16 ` [PATCH v2 net-next 06/23] netlink: Add new socket option to enable strict checking on dumps David Ahern
2018-10-08 10:04   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 07/23] net/ipv4: Update inet_dump_ifaddr for strict data checking David Ahern
2018-10-08 10:06   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 08/23] net/ipv6: Update inet6_dump_addr " David Ahern
2018-10-08 10:10   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 09/23] rtnetlink: Update rtnl_dump_ifinfo " David Ahern
2018-10-08 10:14   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 10/23] rtnetlink: Update rtnl_bridge_getlink " David Ahern
2018-10-08 10:15   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 11/23] rtnetlink: Update rtnl_stats_dump " David Ahern
2018-10-08 10:17   ` Christian Brauner
2018-10-08 13:25     ` David Ahern
2018-10-08 18:02       ` David Miller
2018-10-08  3:16 ` [PATCH v2 net-next 12/23] rtnetlink: Update inet6_dump_ifinfo " David Ahern
2018-10-08 10:18   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 13/23] rtnetlink: Update ipmr_rtm_dumplink " David Ahern
2018-10-08 10:43   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 14/23] rtnetlink: Update fib dumps " David Ahern
2018-10-08  3:16 ` [PATCH v2 net-next 15/23] net/neighbor: Update neigh_dump_info " David Ahern
2018-10-08 10:47   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 16/23] net/neighbor: Update neightbl_dump_info " David Ahern
2018-10-08 10:47   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 17/23] net/namespace: Update rtnl_net_dumpid " David Ahern
2018-10-08 10:54   ` Christian Brauner
2018-10-08 13:28     ` David Ahern
2018-10-08 13:37       ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 18/23] net/fib_rules: Update fib_nl_dumprule " David Ahern
2018-10-08 10:48   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 19/23] net/ipv6: Update ip6addrlbl_dump " David Ahern
2018-10-08 10:51   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 20/23] net: Update netconf dump handlers " David Ahern
2018-10-08 10:51   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 21/23] net/bridge: Update br_mdb_dump " David Ahern
2018-10-08 10:55   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 22/23] rtnetlink: Move input checking for rtnl_fdb_dump to helper David Ahern
2018-10-08 11:01   ` Christian Brauner
2018-10-08  3:16 ` [PATCH v2 net-next 23/23] rtnetlink: Update rtnl_fdb_dump for strict data checking David Ahern
2018-10-08 11:02   ` Christian Brauner
2018-10-08 11:04 ` [PATCH v2 net-next 00/23] rtnetlink: Add support for rigid checking of data in dump request Christian Brauner
2018-10-08 17:40   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008031644.15989-3-dsahern@kernel.org \
    --to=dsahern@kernel.org \
    --cc=christian@brauner.io \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jbenc@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).