From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: jhs@mojatatu.com, jiri@resnulli.us, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements
Date: Mon, 8 Oct 2018 07:11:12 +0100 [thread overview]
Message-ID: <20181008061112.GD32577@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20181007.225552.488756286647781616.davem@davemloft.net>
On Sun, Oct 07, 2018 at 10:55:52PM -0700, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Mon, 8 Oct 2018 06:45:15 +0100
>
> > Er... Both are due to missing in the very beginning of the series (well, on
> > top of "net: sched: cls_u32: fix hnode refcounting") commit
>
> All dependencies like this must be explicitly stated.
>
> And in such situations you actually should wait for the dependency to
> get into 'net', eventually get merged into 'net-next', and then you
> can submit the stuff that depends upon it.
>
> Not the way this was done.
Point (and this commit is simply missing - it's not that it went into
net). FWIW, this was simply "this is what the breakage is caused by",
not an attempt to amend the submission or anything like that...
next prev parent reply other threads:[~2018-10-08 13:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 16:38 [PATCH net-next 00/11] net: sched: cls_u32 Various improvements Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 01/11] net: sched: cls_u32: disallow linking to root hnode Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 02/11] net: sched: cls_u32: make sure that divisor is a power of 2 Jamal Hadi Salim
2018-10-08 8:46 ` Sergei Shtylyov
2018-10-08 9:49 ` Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 03/11] net: sched: cls_u32: get rid of unused argument of u32_destroy_key() Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 04/11] net: sched: cls_u32: get rid of tc_u_knode ->tp Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 05/11] net: sched: cls_u32: get rid of tc_u_common ->rcu Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 06/11] net: sched: cls_u32: clean tc_u_common hashtable Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 07/11] net: sched: cls_u32: pass tc_u_common to u32_set_parms() instead of tc_u_hnode Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 08/11] net: sched: cls_u32: the tp_c argument of u32_set_parms() is always tp->data Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 09/11] net: sched: cls_u32: get rid of tp_c Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 10/11] net: sched: cls_u32: keep track of knodes count in tc_u_common Jamal Hadi Salim
2018-10-07 16:38 ` [PATCH net-next 11/11] net: sched: cls_u32: simplify the hell out u32_delete() emptiness check Jamal Hadi Salim
2018-10-08 4:25 ` [PATCH net-next 00/11] net: sched: cls_u32 Various improvements David Miller
2018-10-08 5:45 ` Al Viro
2018-10-08 5:55 ` David Miller
2018-10-08 6:11 ` Al Viro [this message]
2018-10-08 9:47 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008061112.GD32577@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).