From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next] net: core: change bool members of struct
 net_device to bitfield members
Date: Mon, 8 Oct 2018 14:20:09 -0700
Message-ID: <20181008142009.7b32df14@xeon-e3>
References: <c1d1e04d-693a-b81e-323a-d04b1dcd6544@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f193.google.com ([209.85.215.193]:34931 "EHLO
        mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725749AbeJIEeA (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 9 Oct 2018 00:34:00 -0400
Received: by mail-pg1-f193.google.com with SMTP id v133-v6so8398004pgb.2
        for <netdev@vger.kernel.org>; Mon, 08 Oct 2018 14:20:18 -0700 (PDT)
In-Reply-To: <c1d1e04d-693a-b81e-323a-d04b1dcd6544@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 8 Oct 2018 22:00:51 +0200
Heiner Kallweit <hkallweit1@gmail.com> wrote:

>   *
> + *	@uc_promisc:	Counter that indicates promiscuous mode
> + *			has been enabled due to the need to listen to
> + *			additional unicast addresses in a device that
> + *			does not implement ndo_set_rx_mode()
> + *

I see you just moved the pre-existing comment, but it the comment
looks incorrect. uc_promisc is not a counter but a flag. A counter would
have more than two states normally.