From: Sabrina Dubroca <sd@queasysnail.net>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, Stefano Brivio <sbrivio@redhat.com>,
Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net 1/2] net: ipv4: update fnhe_pmtu when first hop's MTU changes
Date: Mon, 8 Oct 2018 23:42:21 +0200 [thread overview]
Message-ID: <20181008214221.GA32465@bistromath.localdomain> (raw)
In-Reply-To: <fa74dac1-bb8e-7892-a48f-1336eda9628f@gmail.com>
2018-10-08, 11:18:49 -0600, David Ahern wrote:
> On 10/8/18 6:36 AM, Sabrina Dubroca wrote:
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index c7861e4b402c..dc9d2668d9bb 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -2458,6 +2458,13 @@ struct netdev_notifier_info {
> > struct netlink_ext_ack *extack;
> > };
> >
> > +struct netdev_notifier_info_ext {
> > + struct netdev_notifier_info info; /* must be first */
> > + union {
> > + u32 u32;
>
> I realize you want this to be generic, but that is a really odd
> definition. can you make that mtu instead? the union allows other use
> cases to add new names.
It might get ugly if we end up with 4 different u32, but ok, I'll
rename this and we can see how it evolves.
--
Sabrina
next prev parent reply other threads:[~2018-10-09 4:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 12:36 [PATCH net 1/2] net: ipv4: update fnhe_pmtu when first hop's MTU changes Sabrina Dubroca
2018-10-08 12:36 ` [PATCH net 2/2] ipv4: don't let PMTU updates increase route MTU Sabrina Dubroca
2018-10-08 17:18 ` [PATCH net 1/2] net: ipv4: update fnhe_pmtu when first hop's MTU changes David Ahern
2018-10-08 21:42 ` Sabrina Dubroca [this message]
2018-10-08 17:58 ` David Miller
2018-10-08 21:16 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008214221.GA32465@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox