From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH iptables] extensions: libxt_quota: Allow setting the remaining quota Date: Tue, 9 Oct 2018 01:16:23 +0200 Message-ID: <20181008231623.wqlhz5zn3f2q3uxl@salvia> References: <1538443388-6881-1-git-send-email-chenbofeng.kernel@gmail.com> <1538443388-6881-2-git-send-email-chenbofeng.kernel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, kernel-team@android.com, Lorenzo Colitti , maze@google.com, Chenbo Feng To: Chenbo Feng Return-path: Received: from mail.us.es ([193.147.175.20]:58580 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbeJIGad (ORCPT ); Tue, 9 Oct 2018 02:30:33 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id E409E53AA3C for ; Tue, 9 Oct 2018 01:16:25 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id CE438DA85E for ; Tue, 9 Oct 2018 01:16:25 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1538443388-6881-2-git-send-email-chenbofeng.kernel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Oct 01, 2018 at 06:23:07PM -0700, Chenbo Feng wrote: > From: Chenbo Feng > > The current xt_quota module cannot track the current remaining quota > of a specific rule. Everytime an unrelated rule is updated in the same > iptables table, the quota will be reset. This is not a very useful > function for iptables that get changed at run time. This patch fixes the > above problem by adding a new field in the struct that records the > current remaining quota. > > Fixed a print out bug in verbose print out wrt. inversion. Applied, thanks. Please, send me a patch to: #1 add tests for iptables-tests.py, see .t file under extensions/ #2 document this new option in the manpage. Thanks again.