From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: mscc: allow extracting the FCS into the skb Date: Wed, 10 Oct 2018 10:26:05 -0700 (PDT) Message-ID: <20181010.102605.1416485422281413445.davem@davemloft.net> References: <20181002124323.GC9155@lunn.ch> <20181010144631.GE3368@kwain> <28179B83-2C71-47FA-9D9C-49237E4A07AE@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: antoine.tenart@bootlin.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, quentin.schulz@bootlin.com, allan.nielsen@microchip.com To: f.fainelli@gmail.com Return-path: In-Reply-To: <28179B83-2C71-47FA-9D9C-49237E4A07AE@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Florian Fainelli Date: Wed, 10 Oct 2018 09:25:01 -0700 > > > On October 10, 2018 7:46:31 AM PDT, Antoine Tenart wrote: >>Hi all, >> >>On Tue, Oct 02, 2018 at 02:43:23PM +0200, Andrew Lunn wrote: >>> > The question could be "do we need len += ETH_FCS_LEN" to account >>for the >>> > FCS when NETIF_F_RXFCS is used", but I looked at other drivers and >>it >>> > seemed to me the FCS is not accounted in the stats. Should it be? >>> >>> There does not appear to be a good answer to that. I submitted a >>patch >>> to a driver i'm using to not count it, so that the stats counters we >>> consistent with another driver. The patch was rejected. >>> >>> I think the best you can do is flip a coin, and then document it >>using >>> a comment about if it is/is not included. >> >>I'll leave it as-is then :) >> >>@Dave, Florian: it seems to me no modification was requested after >>discussing those changes. Where do we stand regarding the patch? > > Silence means agreement, thanks for your explanation, no more questions or concerns on my side. You'll probably need to resubmit the patch anew though.