From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check in serdes_probe() Date: Wed, 10 Oct 2018 22:54:47 -0700 (PDT) Message-ID: <20181010.225447.2264091665828087261.davem@davemloft.net> References: <1539136824-44940-1-git-send-email-weiyongjun1@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kishon@ti.com, quentin.schulz@bootlin.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org To: weiyongjun1@huawei.com Return-path: In-Reply-To: <1539136824-44940-1-git-send-email-weiyongjun1@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Wei Yongjun Date: Wed, 10 Oct 2018 02:00:24 +0000 > In case of error, the function syscon_node_to_regmap() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot SerDes muxing") > Signed-off-by: Wei Yongjun Applied.