From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net 1/1] tipc: set link tolerance correctly in broadcast link Date: Wed, 10 Oct 2018 22:56:52 -0700 (PDT) Message-ID: <20181010.225652.206935836434769992.davem@davemloft.net> References: <1539185641-32711-1-git-send-email-jon.maloy@ericsson.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, gordan.mihaljevic@dektech.com.au, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, canh.d.luu@dektech.com.au, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net To: jon.maloy@ericsson.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:49260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727065AbeJKNWf (ORCPT ); Thu, 11 Oct 2018 09:22:35 -0400 In-Reply-To: <1539185641-32711-1-git-send-email-jon.maloy@ericsson.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jon Maloy Date: Wed, 10 Oct 2018 17:34:01 +0200 > In the patch referred to below we added link tolerance as an additional > criteria for declaring broadcast transmission "stale" and resetting the > affected links. > > However, the 'tolerance' field of the broadcast link is never set, and > remains at zero. This renders the whole commit without the intended > improving effect, but luckily also with no negative effect. > > In this commit we add the missing initialization. > > Fixes: a4dc70d46cf1 ("tipc: extend link reset criteria for stale packet > retransmission") > > Signed-off-by: Jon Maloy Applied.