From: Mark Brown <broonie@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Ben Whitten <ben.whitten@gmail.com>,
starnight@g.ncu.edu.tw, hasnain.virk@arm.com,
netdev@vger.kernel.org, liuxuenetmail@gmail.com,
shess@hessware.de, Ben Whitten <ben.whitten@lairdtech.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
Stefan Popa <stefan.popa@analog.com>
Subject: Re: [PATCH v2 lora-next 1/4] net: lora: sx1301: convert burst spi functions to regmap raw
Date: Wed, 10 Oct 2018 11:19:54 +0100 [thread overview]
Message-ID: <20181010101954.GB6294@sirena.org.uk> (raw)
In-Reply-To: <3959c93b-edb5-c6ff-ec36-57f84ab8623f@suse.de>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
On Wed, Oct 10, 2018 at 09:59:29AM +0200, Andreas Färber wrote:
> Am 09.10.18 um 14:52 schrieb Ben Whitten:
> > - return spi_sync_transfer(priv->spi, xfr, 2);
> > + return regmap_raw_write(priv->regmap, reg, val, len);
> ... Which would mean we are lacking a noinc API for write here!
> @Mark/Stefan, any reason noinc was not implemented symmetrically?
Nobody wanted it enough to do the work of implementing it, there's
nothing stopping someone doing that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-10-10 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 12:52 [PATCH v2 lora-next 0/4] migration to regmap and clk framework Ben Whitten
2018-10-09 12:52 ` [PATCH v2 lora-next 1/4] net: lora: sx1301: convert burst spi functions to regmap raw Ben Whitten
2018-10-10 7:59 ` Andreas Färber
2018-10-10 9:22 ` Ben Whitten
2018-10-10 10:19 ` Mark Brown [this message]
2018-10-09 12:52 ` [PATCH v2 lora-next 2/4] net: lora: sx1301: convert to using regmap fields for bit ops Ben Whitten
2018-10-09 12:52 ` [PATCH v2 lora-next 3/4] net: lora: sx125x: convert to regmap fields Ben Whitten
2018-10-09 12:52 ` [PATCH v2 lora-next 4/4] net: lora: sx125x sx1301: allow radio to register as a clk provider Ben Whitten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010101954.GB6294@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afaerber@suse.de \
--cc=ben.whitten@gmail.com \
--cc=ben.whitten@lairdtech.com \
--cc=hasnain.virk@arm.com \
--cc=linux-spi@vger.kernel.org \
--cc=liuxuenetmail@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shess@hessware.de \
--cc=starnight@g.ncu.edu.tw \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).