From: Stephen Hemminger <stephen@networkplumber.org>
To: Laurent Bigonville <bigon@bigon.be>
Cc: netdev@vger.kernel.org
Subject: Re: [sky2 driver] 88E8056 PCI-E Gigabit Ethernet Controller not working after suspend
Date: Wed, 10 Oct 2018 12:09:22 -0700 [thread overview]
Message-ID: <20181010120922.6831b0fe@xeon-e3> (raw)
In-Reply-To: <aa7dd2f9-fc1a-6b59-3f9a-716dfbc4de9b@bigon.be>
On Wed, 10 Oct 2018 03:16:40 +0200
Laurent Bigonville <bigon@bigon.be> wrote:
> Le 9/10/18 à 22:09, Stephen Hemminger a écrit :
> > On Tue, 9 Oct 2018 19:30:30 +0200
> > Laurent Bigonville <bigon@bigon.be> wrote:
> >
> >> Hello,
> >>
> >> On my desktop (Asus MB with dual Ethernet port), when waking up after
> >> suspend, the network card is not detecting the link.
> >>
> >> I have to rmmod the sky2 driver and then modprobing it again.
> >>
> >> lspci shows me:
> >>
> >> 04:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI-E
> >> Gigabit Ethernet Controller (rev 12)
> >> 05:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI-E
> >> Gigabit Ethernet Controller (rev 12)
> >>
> >> An idea what's wrong here?
> >>
> >> Kind regards,
> >>
> >> Laurent Bigonville
> >>
> > I used to have that motherboard (about 8 years ago). Long dead by now.
> >
> > There was some issue with how the power management worked. Forgot the workaround,
> > you might have to dig in the mailing list archive.
>
> I've made some test and it seems that this was working in 4.14 and then
> broken in 4.15 (using the debian kernel pkg), so it was working not that
> long ago:
>
> The only commit I see to the sky2 driver is the following:
>
> commit e99e88a9d2b067465adaa9c111ada99a041bef9a
> Author: Kees Cook <keescook@chromium.org>
> Date: Mon Oct 16 14:43:17 2017 -0700
>
> treewide: setup_timer() -> timer_setup()
>
> This converts all remaining cases of the old setup_timer() API into
> using
> timer_setup(), where the callback argument is the structure already
> holding the struct timer_list. These should have no behavioral changes,
> since they just change which pointer is passed into the callback with
> the same available pointers after conversion. It handles the following
> examples, in addition to some other variations.
>
>
Probably something in PCI power management could.
next prev parent reply other threads:[~2018-10-11 2:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 17:30 [sky2 driver] 88E8056 PCI-E Gigabit Ethernet Controller not working after suspend Laurent Bigonville
2018-10-09 20:09 ` Stephen Hemminger
2018-10-10 1:16 ` Laurent Bigonville
2018-10-10 19:09 ` Stephen Hemminger [this message]
2018-11-30 11:16 ` Laurent Bigonville
2018-12-05 1:07 ` Laurent Bigonville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010120922.6831b0fe@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bigon@bigon.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).