From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Tenart Subject: Re: [PATCH net-next] net: mscc: allow extracting the FCS into the skb Date: Wed, 10 Oct 2018 16:46:31 +0200 Message-ID: <20181010144631.GE3368@kwain> References: <20181001095714.26024-1-antoine.tenart@bootlin.com> <25a88126-2397-a1fb-0c0d-06504bb348ca@gmail.com> <20181002065937.GB3368@kwain> <20181002124323.GC9155@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Antoine Tenart , Florian Fainelli , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, quentin.schulz@bootlin.com, allan.nielsen@microchip.com To: Andrew Lunn Return-path: Content-Disposition: inline In-Reply-To: <20181002124323.GC9155@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi all, On Tue, Oct 02, 2018 at 02:43:23PM +0200, Andrew Lunn wrote: > > The question could be "do we need len += ETH_FCS_LEN" to account for the > > FCS when NETIF_F_RXFCS is used", but I looked at other drivers and it > > seemed to me the FCS is not accounted in the stats. Should it be? > > There does not appear to be a good answer to that. I submitted a patch > to a driver i'm using to not count it, so that the stats counters we > consistent with another driver. The patch was rejected. > > I think the best you can do is flip a coin, and then document it using > a comment about if it is/is not included. I'll leave it as-is then :) @Dave, Florian: it seems to me no modification was requested after discussing those changes. Where do we stand regarding the patch? Thanks! Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com