From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, gregkh@linuxfoundation.org,
stable@vger.kernel.org, edumazet@google.com,
sthemmin@microsoft.com
Subject: [PATCH stable 4.9 v2 16/29] inet: frags: reorganize struct netns_frags
Date: Wed, 10 Oct 2018 12:30:04 -0700 [thread overview]
Message-ID: <20181010193017.25221-17-f.fainelli@gmail.com> (raw)
In-Reply-To: <20181010193017.25221-1-f.fainelli@gmail.com>
From: Eric Dumazet <edumazet@google.com>
Put the read-mostly fields in a separate cache line
at the beginning of struct netns_frags, to reduce
false sharing noticed in inet_frag_kill()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit c2615cf5a761b32bf74e85bddc223dfff3d9b9f0)
---
include/net/inet_frag.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h
index dea175f3418a..f47678d2ccc2 100644
--- a/include/net/inet_frag.h
+++ b/include/net/inet_frag.h
@@ -4,16 +4,17 @@
#include <linux/rhashtable.h>
struct netns_frags {
- struct rhashtable rhashtable ____cacheline_aligned_in_smp;
-
- /* Keep atomic mem on separate cachelines in structs that include it */
- atomic_long_t mem ____cacheline_aligned_in_smp;
/* sysctls */
long high_thresh;
long low_thresh;
int timeout;
int max_dist;
struct inet_frags *f;
+
+ struct rhashtable rhashtable ____cacheline_aligned_in_smp;
+
+ /* Keep atomic mem on separate cachelines in structs that include it */
+ atomic_long_t mem ____cacheline_aligned_in_smp;
};
/**
--
2.17.1
next prev parent reply other threads:[~2018-10-10 19:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 19:29 [PATCH stable 4.9 v2 00/29] backport of IP fragmentation fixes Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 01/29] inet: frags: change inet_frags_init_net() return value Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 02/29] inet: frags: add a pointer to struct netns_frags Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 03/29] inet: frags: refactor ipfrag_init() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 04/29] inet: frags: refactor ipv6_frag_init() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 05/29] inet: frags: refactor lowpan_net_frag_init() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 06/29] ipv6: export ip6 fragments sysctl to unprivileged users Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 07/29] rhashtable: add schedule points Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 08/29] inet: frags: use rhashtables for reassembly units Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 09/29] inet: frags: remove some helpers Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 10/29] inet: frags: get rif of inet_frag_evicting() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 11/29] inet: frags: remove inet_frag_maybe_warn_overflow() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 12/29] inet: frags: break the 2GB limit for frags storage Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 13/29] inet: frags: do not clone skb in ip_expire() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 14/29] ipv6: frags: rewrite ip6_expire_frag_queue() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 15/29] rhashtable: reorganize struct rhashtable layout Florian Fainelli
2018-10-10 19:30 ` Florian Fainelli [this message]
2018-10-10 19:30 ` [PATCH stable 4.9 v2 17/29] inet: frags: get rid of ipfrag_skb_cb/FRAG_CB Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 18/29] inet: frags: fix ip6frag_low_thresh boundary Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 19/29] ip: discard IPv4 datagrams with overlapping segments Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 20/29] net: speed up skb_rbtree_purge() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 21/29] net: modify skb_rbtree_purge to return the truesize of all purged skbs Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 22/29] ipv6: defrag: drop non-last frags smaller than min mtu Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 23/29] net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 24/29] net: add rb_to_skb() and other rb tree helpers Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 25/29] ip: use rb trees for IP frag queue Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 26/29] ip: add helpers to process in-order fragments faster Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 27/29] ip: process in-order fragments efficiently Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 28/29] ip: frags: fix crash in ip_do_fragment() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 29/29] ipv4: frags: precedence bug in ip_expire() Florian Fainelli
2018-10-15 17:47 ` [PATCH stable 4.9 v2 00/29] backport of IP fragmentation fixes Florian Fainelli
2018-10-15 17:53 ` Eric Dumazet
2018-10-16 16:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010193017.25221-17-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).