From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, gregkh@linuxfoundation.org,
stable@vger.kernel.org, edumazet@google.com,
sthemmin@microsoft.com, Peter Oskolkov <posk@google.com>,
Florian Westphal <fw@strlen.de>
Subject: [PATCH stable 4.9 v2 21/29] net: modify skb_rbtree_purge to return the truesize of all purged skbs.
Date: Wed, 10 Oct 2018 12:30:09 -0700 [thread overview]
Message-ID: <20181010193017.25221-22-f.fainelli@gmail.com> (raw)
In-Reply-To: <20181010193017.25221-1-f.fainelli@gmail.com>
From: Peter Oskolkov <posk@google.com>
Tested: see the next patch is the series.
Suggested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Peter Oskolkov <posk@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 385114dec8a49b5e5945e77ba7de6356106713f4)
---
include/linux/skbuff.h | 2 +-
net/core/skbuff.c | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index c7cca35fcf6d..724c6abdb9e6 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2418,7 +2418,7 @@ static inline void __skb_queue_purge(struct sk_buff_head *list)
kfree_skb(skb);
}
-void skb_rbtree_purge(struct rb_root *root);
+unsigned int skb_rbtree_purge(struct rb_root *root);
void *netdev_alloc_frag(unsigned int fragsz);
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 96a553da1518..4e545e4432eb 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2425,23 +2425,27 @@ EXPORT_SYMBOL(skb_queue_purge);
/**
* skb_rbtree_purge - empty a skb rbtree
* @root: root of the rbtree to empty
+ * Return value: the sum of truesizes of all purged skbs.
*
* Delete all buffers on an &sk_buff rbtree. Each buffer is removed from
* the list and one reference dropped. This function does not take
* any lock. Synchronization should be handled by the caller (e.g., TCP
* out-of-order queue is protected by the socket lock).
*/
-void skb_rbtree_purge(struct rb_root *root)
+unsigned int skb_rbtree_purge(struct rb_root *root)
{
struct rb_node *p = rb_first(root);
+ unsigned int sum = 0;
while (p) {
struct sk_buff *skb = rb_entry(p, struct sk_buff, rbnode);
p = rb_next(p);
rb_erase(&skb->rbnode, root);
+ sum += skb->truesize;
kfree_skb(skb);
}
+ return sum;
}
/**
--
2.17.1
next prev parent reply other threads:[~2018-10-11 2:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 19:29 [PATCH stable 4.9 v2 00/29] backport of IP fragmentation fixes Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 01/29] inet: frags: change inet_frags_init_net() return value Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 02/29] inet: frags: add a pointer to struct netns_frags Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 03/29] inet: frags: refactor ipfrag_init() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 04/29] inet: frags: refactor ipv6_frag_init() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 05/29] inet: frags: refactor lowpan_net_frag_init() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 06/29] ipv6: export ip6 fragments sysctl to unprivileged users Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 07/29] rhashtable: add schedule points Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 08/29] inet: frags: use rhashtables for reassembly units Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 09/29] inet: frags: remove some helpers Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 10/29] inet: frags: get rif of inet_frag_evicting() Florian Fainelli
2018-10-10 19:29 ` [PATCH stable 4.9 v2 11/29] inet: frags: remove inet_frag_maybe_warn_overflow() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 12/29] inet: frags: break the 2GB limit for frags storage Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 13/29] inet: frags: do not clone skb in ip_expire() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 14/29] ipv6: frags: rewrite ip6_expire_frag_queue() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 15/29] rhashtable: reorganize struct rhashtable layout Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 16/29] inet: frags: reorganize struct netns_frags Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 17/29] inet: frags: get rid of ipfrag_skb_cb/FRAG_CB Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 18/29] inet: frags: fix ip6frag_low_thresh boundary Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 19/29] ip: discard IPv4 datagrams with overlapping segments Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 20/29] net: speed up skb_rbtree_purge() Florian Fainelli
2018-10-10 19:30 ` Florian Fainelli [this message]
2018-10-10 19:30 ` [PATCH stable 4.9 v2 22/29] ipv6: defrag: drop non-last frags smaller than min mtu Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 23/29] net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 24/29] net: add rb_to_skb() and other rb tree helpers Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 25/29] ip: use rb trees for IP frag queue Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 26/29] ip: add helpers to process in-order fragments faster Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 27/29] ip: process in-order fragments efficiently Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 28/29] ip: frags: fix crash in ip_do_fragment() Florian Fainelli
2018-10-10 19:30 ` [PATCH stable 4.9 v2 29/29] ipv4: frags: precedence bug in ip_expire() Florian Fainelli
2018-10-15 17:47 ` [PATCH stable 4.9 v2 00/29] backport of IP fragmentation fixes Florian Fainelli
2018-10-15 17:53 ` Eric Dumazet
2018-10-16 16:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010193017.25221-22-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).