From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2-next] tipc: support interface name when activating
 UDP bearer
Date: Thu, 11 Oct 2018 08:04:35 -0700
Message-ID: <20181011080435.25d4827a@xeon-e3>
References: <20181011020708.7585-1-hoang.h.le@dektech.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: jon.maloy@ericsson.com, maloy@donjonn.com, ying.xue@windriver.com,
        netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net
To: Hoang Le <hoang.h.le@dektech.com.au>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f194.google.com ([209.85.210.194]:40424 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726537AbeJKWcQ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 11 Oct 2018 18:32:16 -0400
Received: by mail-pf1-f194.google.com with SMTP id s5-v6so4565181pfj.7
        for <netdev@vger.kernel.org>; Thu, 11 Oct 2018 08:04:43 -0700 (PDT)
In-Reply-To: <20181011020708.7585-1-hoang.h.le@dektech.com.au>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 11 Oct 2018 09:07:08 +0700
Hoang Le <hoang.h.le@dektech.com.au> wrote:

This looks fine.

> +static int cmd_bearer_validate_and_get_addr(const char *name, char *straddr)
> +{
> +	struct ifreq ifc;
> +	struct sockaddr_in *ip4addr;
> +	struct sockaddr_in6 *ip6addr;
> +	int fd = 0;
> +
> +	if (!name || !straddr)
> +		return 0;
> +
> +	fd = socket(PF_INET, SOCK_DGRAM, 0);

Will goahead and apply but minor nits.

The initialization of fd to zero is unnecessary.
This function is return 0, -1, or -EINVAL but only caller only cares about
zero or non-zero.