From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Howells <dhowells@redhat.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
davem@davemloft.net, linux-afs@lists.infradead.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
Date: Thu, 11 Oct 2018 11:38:08 +0300 [thread overview]
Message-ID: <20181011083807.tvhfguimyw7glrtp@mwanda> (raw)
In-Reply-To: <11853.1539079996@warthog.procyon.org.uk>
On Tue, Oct 09, 2018 at 11:13:16AM +0100, David Howells wrote:
> YueHaibing <yuehaibing@huawei.com> wrote:
>
> > net/rxrpc/output.c: In function 'rxrpc_reject_packets':
> > net/rxrpc/output.c:527:11: warning:
> > variable 'ioc' set but not used [-Wunused-but-set-variable]
> >
> > It never used since introduction in
>
> I wonder why my compiler doesn't show this warning.
>
> Anyway, NAK: just removing the variable is the wrong fix - you need to look at
> the code more closely. The actual fix is to pass it to kernel_sendmsg()
> instead of 2.
>
> But thanks anyway! Do you want to respin your patch?
>
> > commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
>
> Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
> to go to net, not net-next.
I told him to do that because it wasn't a bugfix... Probably just Fixes
is the right thing to use though.
regards,
dan carpenter
next prev parent reply other threads:[~2018-10-11 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 2:31 [PATCH net-next] rxrpc: Remove set but not used variable 'ioc' YueHaibing
2018-10-09 10:13 ` David Howells
2018-10-09 12:04 ` YueHaibing
2018-10-11 8:38 ` Dan Carpenter [this message]
2018-10-11 20:38 ` David Howells
2018-10-09 14:15 ` [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets YueHaibing
2018-10-09 15:34 ` Sergei Shtylyov
2018-10-10 1:19 ` YueHaibing
2018-10-10 2:06 ` [PATCH v3] " YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011083807.tvhfguimyw7glrtp@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).