From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc' Date: Thu, 11 Oct 2018 11:38:08 +0300 Message-ID: <20181011083807.tvhfguimyw7glrtp@mwanda> References: <1539052273-34824-1-git-send-email-yuehaibing@huawei.com> <11853.1539079996@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: YueHaibing , davem@davemloft.net, linux-afs@lists.infradead.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: David Howells Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:60956 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727822AbeJKQEv (ORCPT ); Thu, 11 Oct 2018 12:04:51 -0400 Content-Disposition: inline In-Reply-To: <11853.1539079996@warthog.procyon.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 09, 2018 at 11:13:16AM +0100, David Howells wrote: > YueHaibing wrote: > > > net/rxrpc/output.c: In function 'rxrpc_reject_packets': > > net/rxrpc/output.c:527:11: warning: > > variable 'ioc' set but not used [-Wunused-but-set-variable] > > > > It never used since introduction in > > I wonder why my compiler doesn't show this warning. > > Anyway, NAK: just removing the variable is the wrong fix - you need to look at > the code more closely. The actual fix is to pass it to kernel_sendmsg() > instead of 2. > > But thanks anyway! Do you want to respin your patch? > > > commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs") > > Btw, this should be a 'Fixes: ("subject")' line and the patch needs > to go to net, not net-next. I told him to do that because it wasn't a bugfix... Probably just Fixes is the right thing to use though. regards, dan carpenter