* [PATCH] net: phy: sfp: remove sfp_mutex's definition
@ 2018-10-11 15:06 Sebastian Andrzej Siewior
2018-10-11 15:45 ` Andrew Lunn
2018-10-11 19:10 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-10-11 15:06 UTC (permalink / raw)
To: netdev
Cc: tglx, Sebastian Andrzej Siewior, Andrew Lunn, Florian Fainelli,
David S. Miller
The sfp_mutex variable is defined but never used in this file. Not even
in the commit that introduced that variable.
Remove sfp_mutex, it has no purpose.
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/net/phy/sfp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 6e13b8832bc7d..fd8bb998ae52d 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -163,8 +163,6 @@ static const enum gpiod_flags gpio_flags[] = {
/* Give this long for the PHY to reset. */
#define T_PHY_RESET_MS 50
-static DEFINE_MUTEX(sfp_mutex);
-
struct sff_data {
unsigned int gpios;
bool (*module_supported)(const struct sfp_eeprom_id *id);
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: sfp: remove sfp_mutex's definition
2018-10-11 15:06 [PATCH] net: phy: sfp: remove sfp_mutex's definition Sebastian Andrzej Siewior
@ 2018-10-11 15:45 ` Andrew Lunn
2018-10-11 19:10 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-10-11 15:45 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: netdev, tglx, Florian Fainelli, David S. Miller
On Thu, Oct 11, 2018 at 05:06:21PM +0200, Sebastian Andrzej Siewior wrote:
> The sfp_mutex variable is defined but never used in this file. Not even
> in the commit that introduced that variable.
>
> Remove sfp_mutex, it has no purpose.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: sfp: remove sfp_mutex's definition
2018-10-11 15:06 [PATCH] net: phy: sfp: remove sfp_mutex's definition Sebastian Andrzej Siewior
2018-10-11 15:45 ` Andrew Lunn
@ 2018-10-11 19:10 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-10-11 19:10 UTC (permalink / raw)
To: bigeasy; +Cc: netdev, tglx, andrew, f.fainelli
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Thu, 11 Oct 2018 17:06:21 +0200
> The sfp_mutex variable is defined but never used in this file. Not even
> in the commit that introduced that variable.
>
> Remove sfp_mutex, it has no purpose.
>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-12 2:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 15:06 [PATCH] net: phy: sfp: remove sfp_mutex's definition Sebastian Andrzej Siewior
2018-10-11 15:45 ` Andrew Lunn
2018-10-11 19:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).