From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6
Date: Fri, 12 Oct 2018 11:11:30 -0700 (PDT)
Message-ID: <20181012.111130.2147603962642962519.davem@davemloft.net>
References: <153935592320.3029.14678717675993366.stgit@warthog.procyon.org.uk>
        <9ee1a767-b865-6afa-91a2-311422b8338d@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: dhowells@redhat.com, arnd@arndb.de, netdev@vger.kernel.org,
        linux-afs@lists.infradead.org
To: eric.dumazet@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:48434 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725981AbeJMBpP (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 12 Oct 2018 21:45:15 -0400
In-Reply-To: <9ee1a767-b865-6afa-91a2-311422b8338d@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 12 Oct 2018 08:19:20 -0700

> 
> 
> On 10/12/2018 07:52 AM, David Howells wrote:
>> The udpv6_encap_enable() function is part of the ipv6 code, and if that is
>> configured as a loadable module and rxrpc is built in then a build failure
>> will occur because the conditional check is wrong:
>> 
>>   net/rxrpc/local_object.o: In function `rxrpc_lookup_local':
>>   local_object.c:(.text+0x2688): undefined reference to `udpv6_encap_enable'
>> 
>> Use the correct config symbol (CONFIG_AF_RXRPC_IPV6) in the conditional
>> check rather than CONFIG_IPV6 as that will do the right thing.
>> 
>> Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook")
>> Signed-off-by: David Howells <dhowells@redhat.com>
>> cc: Arnd Bergmann <arnd@arndb.de>
> 
> Nit : Correct attribution would require a Reported-by: tag

Right.