From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH] igb: shorten maximum PHC timecounter update interval Date: Fri, 12 Oct 2018 07:05:30 -0700 Message-ID: <20181012140530.6mjxkb2co3nhl5pf@localhost> References: <20181012111339.1361-1-mlichvar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Jacob Keller , Thomas Gleixner To: Miroslav Lichvar Return-path: Received: from mail-pg1-f176.google.com ([209.85.215.176]:36270 "EHLO mail-pg1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727556AbeJLViJ (ORCPT ); Fri, 12 Oct 2018 17:38:09 -0400 Received: by mail-pg1-f176.google.com with SMTP id f18-v6so5916381pgv.3 for ; Fri, 12 Oct 2018 07:05:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181012111339.1361-1-mlichvar@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Oct 12, 2018 at 01:13:39PM +0200, Miroslav Lichvar wrote: > Since commit 500462a9d ("timers: Switch to a non-cascading wheel"), > scheduling of delayed work seems to be less accurate and a requested > delay of 540 seconds may actually be longer than 550 seconds. Shorten > the delay to 480 seconds to be sure the timecounter is updated in time. Good catch. This timer wheel change will affect other, similar drivers. Guess I'll go through and adjust their timeouts, too. Thanks, Richard