From: Stefano Brivio <sbrivio@redhat.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@fb.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md
Date: Fri, 12 Oct 2018 18:34:38 +0200 [thread overview]
Message-ID: <20181012183438.59f4308e@epycfail> (raw)
In-Reply-To: <8622979d-ea2d-82e2-600e-c0dd7d7e3e8a@6wind.com>
On Fri, 12 Oct 2018 17:58:55 +0200
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Le 12/10/2018 à 14:32, Stefano Brivio a écrit :
> > Commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6
> > tunnels") introduced a check to avoid updating PMTU when
> > collect_md mode is enabled.
> >
> > Later, commit f15ca723c1eb ("net: don't call update_pmtu
> > unconditionally") dropped this check, I guess inadvertently.
> I removed it because update_pmtu() is not set for md_dst_op, thus I assume this
> check was done for that purpose.
Ha, sounds reasonable, yes.
> Could you explain in your commit log which problem your patch fixes?
Nothing really.
The change in f15ca723c1eb looked accidental and I thought it doesn't
make sense to update the PMTU in that case, but I didn't figure out
it's not actually done anyway.
Maybe it makes things a bit more readable, in that case I'd target it
for net-next. What do you think?
--
Stefano
next prev parent reply other threads:[~2018-10-13 0:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 12:32 [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md Stefano Brivio
2018-10-12 15:58 ` Nicolas Dichtel
2018-10-12 16:34 ` Stefano Brivio [this message]
2018-10-15 8:48 ` Nicolas Dichtel
2018-10-15 9:09 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012183438.59f4308e@epycfail \
--to=sbrivio@redhat.com \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).