From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md Date: Fri, 12 Oct 2018 18:34:38 +0200 Message-ID: <20181012183438.59f4308e@epycfail> References: <5893664877d77075e32b33f72a7784f539555da0.1539266541.git.sbrivio@redhat.com> <8622979d-ea2d-82e2-600e-c0dd7d7e3e8a@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: "David S. Miller" , Alexei Starovoitov , netdev@vger.kernel.org To: Nicolas Dichtel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34580 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728537AbeJMAID (ORCPT ); Fri, 12 Oct 2018 20:08:03 -0400 In-Reply-To: <8622979d-ea2d-82e2-600e-c0dd7d7e3e8a@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 12 Oct 2018 17:58:55 +0200 Nicolas Dichtel wrote: > Le 12/10/2018 à 14:32, Stefano Brivio a écrit : > > Commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 > > tunnels") introduced a check to avoid updating PMTU when > > collect_md mode is enabled. > > > > Later, commit f15ca723c1eb ("net: don't call update_pmtu > > unconditionally") dropped this check, I guess inadvertently. > I removed it because update_pmtu() is not set for md_dst_op, thus I assume this > check was done for that purpose. Ha, sounds reasonable, yes. > Could you explain in your commit log which problem your patch fixes? Nothing really. The change in f15ca723c1eb looked accidental and I thought it doesn't make sense to update the PMTU in that case, but I didn't figure out it's not actually done anyway. Maybe it makes things a bit more readable, in that case I'd target it for net-next. What do you think? -- Stefano