From: David Miller <davem@davemloft.net>
To: mwb@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
alexander.h.duyck@intel.com, tyhicks@canonical.com,
jeffrey.t.kirsher@intel.com, amritha.nambiar@intel.com,
joe@perches.com, dmitry.torokhov@gmail.com, decot@googlers.com,
roopa@cumulusnetworks.com, xiyou.wangcong@gmail.com,
nfont@linux.vnet.ibm.com, minkim@us.ibm.com,
tyreld@linux.vnet.ibm.com, tlfalcon@linux.vnet.ibm.com
Subject: Re: [PATCH] net/sysfs: Remove devices without receive buffers
Date: Sat, 13 Oct 2018 16:50:56 -0700 (PDT) [thread overview]
Message-ID: <20181013.165056.111476046287532695.davem@davemloft.net> (raw)
In-Reply-To: <20181013220451.6905.65084.stgit@ltcalpine2-lp9.aus.stglabs.ibm.com>
From: Michael Bringmann <mwb@linux.vnet.ibm.com>
Date: Sat, 13 Oct 2018 17:05:28 -0500
> Testing ran into a case where a network device was created and
> initialized, but then removed from the system before accepting
> traffic through it. In this case, no receive buffers were added
> to the device prior to attempting to release the driver. This
> resulted in generation of a WARNING notice/stack trace in the
> console log like,
That's not legal.
The device must setup all of this kind of state before calling
register_netdevice(). And this must happen for reasons other than the
crash situation mentioned here.
Please fix the ibmvnic driver to not register partially setup netdev
objects.
Thank you.
prev parent reply other threads:[~2018-10-14 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 22:05 [PATCH] net/sysfs: Remove devices without receive buffers Michael Bringmann
2018-10-13 23:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013.165056.111476046287532695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=decot@googlers.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minkim@us.ibm.com \
--cc=mwb@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=roopa@cumulusnetworks.com \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=tyhicks@canonical.com \
--cc=tyreld@linux.vnet.ibm.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox