From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic version Date: Sat, 13 Oct 2018 12:01:00 +0000 (UTC) Message-ID: <20181013120100.A423160866@smtp.codeaurora.org> References: <20181008085028.23874-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Ping-Ke Shih , "David S . Miller" , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Colin King Return-path: In-Reply-To: <20181008085028.23874-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Colin King wrote: > From: Colin Ian King > > Function _rtl8821ae_mrate_idx_to_arfr_id is functionally identical to > the generic version rtl_mrate_idx_to_arfr_id, so remove > _rtl8821ae_mrate_idx_to_arfr_id and use the generic one instead. > > This also fixes a missing break statement found by CoverityScan in > _rtl8821ae_mrate_idx_to_arfr_id, namely: CID#1167237 ("Missing break > in switch") > > Thanks to Joe Perches for spotting this when I submitted an earlier patch. > > Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver") > Signed-off-by: Colin Ian King > ACKed-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. c894696188d5 rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic version -- https://patchwork.kernel.org/patch/10630249/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches