From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] ath10k: remove unnecessary comparison of unsigned integer with < 0 Date: Sat, 13 Oct 2018 17:24:21 +0000 (UTC) Message-ID: <20181013172421.88FA860C1D@smtp.codeaurora.org> References: <20181005185623.GA14405@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "Gustavo A. R. Silva" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S. Miller" To: "Gustavo A. R. Silva" Return-path: In-Reply-To: <20181005185623.GA14405@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+gldad-ath10k=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org "Gustavo A. R. Silva" wrote: > There is no need to compare *ps_state_enable* with < 0 because > such variable is of type u8 (8 bits, unsigned), making it > impossible to hold a negative value. > > Fix this by removing such comparison. > > Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0") > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7bfd82bff60e ath10k: remove unnecessary comparison of unsigned integer with < 0 -- https://patchwork.kernel.org/patch/10628679/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches