From: David Miller <davem@davemloft.net>
To: kyeongdon.kim@lge.com
Cc: ktkhai@virtuozzo.com, viro@zeniv.linux.org.uk,
garsilva@embeddedor.com, jbaron@akamai.com, dvlasenk@redhat.com,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: fix waring in af_unix
Date: Mon, 15 Oct 2018 22:16:02 -0700 (PDT) [thread overview]
Message-ID: <20181015.221602.1800911512004774943.davem@davemloft.net> (raw)
In-Reply-To: <1539340454-67970-1-git-send-email-kyeongdon.kim@lge.com>
From: Kyeongdon Kim <kyeongdon.kim@lge.com>
Date: Fri, 12 Oct 2018 19:34:14 +0900
> This fixes the "'hash' may be used uninitialized in this function"
>
> net/unix/af_unix.c:1041:20: warning: 'hash' may be used uninitialized in this function [-Wmaybe-uninitialized]
> addr->hash = hash ^ sk->sk_type;
> ^
>
> Signed-off-by: Kyeongdon Kim <kyeongdon.kim@lge.com>
Please put the initialization at the start of unix_mkname() as a similar
situation exists elsewhere in this file, and the compiler will eventually
warn there too.
prev parent reply other threads:[~2018-10-16 5:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 10:34 [PATCH] net: fix waring in af_unix Kyeongdon Kim
2018-10-16 5:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015.221602.1800911512004774943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=garsilva@embeddedor.com \
--cc=jbaron@akamai.com \
--cc=ktkhai@virtuozzo.com \
--cc=kyeongdon.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox