From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ipv6: rate-limit probes for neighbourless routes Date: Mon, 15 Oct 2018 22:20:46 -0700 (PDT) Message-ID: <20181015.222046.157728514819113366.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sbrivio@redhat.com To: sd@queasysnail.net Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43670 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727008AbeJPNJ0 (ORCPT ); Tue, 16 Oct 2018 09:09:26 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Sabrina Dubroca Date: Fri, 12 Oct 2018 16:22:47 +0200 > When commit 270972554c91 ("[IPV6]: ROUTE: Add Router Reachability > Probing (RFC4191).") introduced router probing, the rt6_probe() function > required that a neighbour entry existed. This neighbour entry is used to > record the timestamp of the last probe via the ->updated field. > > Later, commit 2152caea7196 ("ipv6: Do not depend on rt->n in rt6_probe().") > removed the requirement for a neighbour entry. Neighbourless routes skip > the interval check and are not rate-limited. > > This patch adds rate-limiting for neighbourless routes, by recording the > timestamp of the last probe in the fib6_info itself. > > Fixes: 2152caea7196 ("ipv6: Do not depend on rt->n in rt6_probe().") > Signed-off-by: Sabrina Dubroca > Reviewed-by: Stefano Brivio Applied and queued up for -stable.