From: Stephen Hemminger <stephen@networkplumber.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2] json: make 0xhex handle u64
Date: Mon, 15 Oct 2018 09:34:19 -0700 [thread overview]
Message-ID: <20181015093419.3cb83797@xeon-e3> (raw)
In-Reply-To: <4342ff99b4111ea2b2867e51e0eb15cbf5b02ad1.1539357365.git.sd@queasysnail.net>
On Fri, 12 Oct 2018 17:34:32 +0200
Sabrina Dubroca <sd@queasysnail.net> wrote:
> Stephen converted macsec's sci to use 0xhex, but 0xhex handles
> unsigned int's, not 64 bits ints. Thus, the output of the "ip macsec
> show" command is mangled, with half of the SCI replaced with 0s:
>
> # ip macsec show
> 11: macsec0: [...]
> cipher suite: GCM-AES-128, using ICV length 16
> TXSC: 0000000001560001 on SA 0
>
> # ip -d link show macsec0
> 11: macsec0@ens3: [...]
> link/ether 52:54:00:12:01:56 brd ff:ff:ff:ff:ff:ff promiscuity 0
> macsec sci 5254001201560001 [...]
>
> where TXSC and sci should match.
>
> Fixes: c0b904de6211 ("macsec: support JSON")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Thanks for finding this. We should add JSON (and macsec) to tests.
prev parent reply other threads:[~2018-10-16 0:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 15:34 [PATCH iproute2] json: make 0xhex handle u64 Sabrina Dubroca
2018-10-15 16:34 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015093419.3cb83797@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).