From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] json: make 0xhex handle u64
Date: Mon, 15 Oct 2018 09:34:19 -0700
Message-ID: <20181015093419.3cb83797@xeon-e3>
References: <4342ff99b4111ea2b2867e51e0eb15cbf5b02ad1.1539357365.git.sd@queasysnail.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f194.google.com ([209.85.210.194]:46958 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726528AbeJPAUT (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 15 Oct 2018 20:20:19 -0400
Received: by mail-pf1-f194.google.com with SMTP id r64-v6so9938690pfb.13
        for <netdev@vger.kernel.org>; Mon, 15 Oct 2018 09:34:22 -0700 (PDT)
In-Reply-To: <4342ff99b4111ea2b2867e51e0eb15cbf5b02ad1.1539357365.git.sd@queasysnail.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 12 Oct 2018 17:34:32 +0200
Sabrina Dubroca <sd@queasysnail.net> wrote:

> Stephen converted macsec's sci to use 0xhex, but 0xhex handles
> unsigned int's, not 64 bits ints. Thus, the output of the "ip macsec
> show" command is mangled, with half of the SCI replaced with 0s:
> 
> # ip macsec show
> 11: macsec0: [...]
>     cipher suite: GCM-AES-128, using ICV length 16
>     TXSC: 0000000001560001 on SA 0
> 
> # ip -d link show macsec0
> 11: macsec0@ens3: [...]
>     link/ether 52:54:00:12:01:56 brd ff:ff:ff:ff:ff:ff promiscuity 0 
>     macsec sci 5254001201560001 [...]
> 
> where TXSC and sci should match.
> 
> Fixes: c0b904de6211 ("macsec: support JSON")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>

Thanks for finding this. We should add JSON (and macsec) to tests.