From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] macsec: fix off-by-one when parsing attributes Date: Mon, 15 Oct 2018 09:36:58 -0700 Message-ID: <20181015093658.7c590e29@xeon-e3> References: <9149b45616600eaa71f1dbbb101f7fe169c13efe.1539357364.git.sd@queasysnail.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, David Ahern To: Sabrina Dubroca Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:43787 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbeJPAW6 (ORCPT ); Mon, 15 Oct 2018 20:22:58 -0400 Received: by mail-pg1-f196.google.com with SMTP id 80-v6so9409231pgh.10 for ; Mon, 15 Oct 2018 09:37:00 -0700 (PDT) In-Reply-To: <9149b45616600eaa71f1dbbb101f7fe169c13efe.1539357364.git.sd@queasysnail.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 12 Oct 2018 17:34:12 +0200 Sabrina Dubroca wrote: > I seem to have had a massive brainfart with uses of > parse_rtattr_nested(). The rtattr* array must have MAX+1 elements, and > the call to parse_rtattr_nested must have MAX as its bound. Let's fix > those. > > Fixes: b26fc590ce62 ("ip: add MACsec support") > Signed-off-by: Sabrina Dubroca Applied, How did it ever work??