From: Stefano Brivio <sbrivio@redhat.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: davem <davem@davemloft.net>, Sabrina Dubroca <sd@queasysnail.net>,
network dev <netdev@vger.kernel.org>
Subject: Re: [PATCH net 2/2] geneve, vxlan: Don't set exceptions if skb->len < mtu
Date: Mon, 15 Oct 2018 10:27:16 +0200 [thread overview]
Message-ID: <20181015102716.2a56623f@redhat.com> (raw)
In-Reply-To: <CADvbK_fVyZA-MzmESYOQmp_pes+X61iftnYtNNU4Y_uqSg2LhQ@mail.gmail.com>
On Mon, 15 Oct 2018 15:01:31 +0900
Xin Long <lucien.xin@gmail.com> wrote:
> On Sat, Oct 13, 2018 at 6:54 AM Stefano Brivio <sbrivio@redhat.com> wrote:
> >
> > We shouldn't abuse exceptions: if the destination MTU is already higher
> > than what we're transmitting, no exception should be created.
> makes sense, shouldn't ip(6) tunnels also do this?
I should probably have mentioned this in the cover letter: in theory
yes, but I'm doing this as preparation for ICMP handling in UDP
tunnels, and those will get selftests soon (once I'm done).
Writing extensive selftests for IP tunnels will take significantly
longer, so I'm not too confident to change this right now. I'd prefer
to address that at a later time.
--
Stefano
next prev parent reply other threads:[~2018-10-15 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 21:53 [PATCH net 0/2] geneve, vxlan: Don't set exceptions if skb->len < mtu Stefano Brivio
2018-10-12 21:53 ` [PATCH net 1/2] geneve, vxlan: Don't check skb_dst() twice Stefano Brivio
2018-10-15 10:19 ` Nicolas Dichtel
2018-10-15 11:08 ` Stefano Brivio
2018-10-15 12:24 ` Nicolas Dichtel
2018-10-12 21:53 ` [PATCH net 2/2] geneve, vxlan: Don't set exceptions if skb->len < mtu Stefano Brivio
2018-10-15 6:01 ` Xin Long
2018-10-15 8:27 ` Stefano Brivio [this message]
2018-10-15 9:40 ` [PATCH net 0/2] " Xin Long
2018-10-18 4:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015102716.2a56623f@redhat.com \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).