From: Stefano Brivio <sbrivio@redhat.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Alexei Starovoitov <ast@fb.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md
Date: Mon, 15 Oct 2018 11:09:19 +0200 [thread overview]
Message-ID: <20181015110919.4c04fcd3@redhat.com> (raw)
In-Reply-To: <eb26ebd1-19e3-e72a-2d90-3793889a635e@6wind.com>
On Mon, 15 Oct 2018 10:48:05 +0200
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Le 12/10/2018 à 18:34, Stefano Brivio a écrit :
> > On Fri, 12 Oct 2018 17:58:55 +0200
> > Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> [snip]
> >> Could you explain in your commit log which problem your patch fixes?
> >
> > Nothing really.
> >
> > The change in f15ca723c1eb looked accidental and I thought it doesn't
> > make sense to update the PMTU in that case, but I didn't figure out
> > it's not actually done anyway.
> >
> > Maybe it makes things a bit more readable, in that case I'd target it
> > for net-next. What do you think?
> >
> I don't think that this patch helps. The purpose of the skb_dst_update_pmtu()
> helper is to hide those things. If one day, update_pmtu is defined for
> md_dst_op, I bet that we won't remove this test.
I see, makes sense.
David, please drop this patch, and sorry for the noise.
--
Stefano
prev parent reply other threads:[~2018-10-15 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 12:32 [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md Stefano Brivio
2018-10-12 15:58 ` Nicolas Dichtel
2018-10-12 16:34 ` Stefano Brivio
2018-10-15 8:48 ` Nicolas Dichtel
2018-10-15 9:09 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015110919.4c04fcd3@redhat.com \
--to=sbrivio@redhat.com \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).