From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md Date: Mon, 15 Oct 2018 11:09:19 +0200 Message-ID: <20181015110919.4c04fcd3@redhat.com> References: <5893664877d77075e32b33f72a7784f539555da0.1539266541.git.sbrivio@redhat.com> <8622979d-ea2d-82e2-600e-c0dd7d7e3e8a@6wind.com> <20181012183438.59f4308e@epycfail> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: Alexei Starovoitov , netdev@vger.kernel.org To: Nicolas Dichtel , "David S. Miller" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbeJOQxt (ORCPT ); Mon, 15 Oct 2018 12:53:49 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 15 Oct 2018 10:48:05 +0200 Nicolas Dichtel wrote: > Le 12/10/2018 à 18:34, Stefano Brivio a écrit : > > On Fri, 12 Oct 2018 17:58:55 +0200 > > Nicolas Dichtel wrote: > [snip] > >> Could you explain in your commit log which problem your patch fixes? > > > > Nothing really. > > > > The change in f15ca723c1eb looked accidental and I thought it doesn't > > make sense to update the PMTU in that case, but I didn't figure out > > it's not actually done anyway. > > > > Maybe it makes things a bit more readable, in that case I'd target it > > for net-next. What do you think? > > > I don't think that this patch helps. The purpose of the skb_dst_update_pmtu() > helper is to hide those things. If one day, update_pmtu is defined for > md_dst_op, I bet that we won't remove this test. I see, makes sense. David, please drop this patch, and sorry for the noise. -- Stefano