From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: [PATCH net-next 4/7] net_sched: sch_fq: no longer use skb_is_tcp_pure_ack() Date: Mon, 15 Oct 2018 09:37:55 -0700 Message-ID: <20181015163758.232436-5-edumazet@google.com> References: <20181015163758.232436-1-edumazet@google.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: netdev , Eric Dumazet , Eric Dumazet To: "David S . Miller" , Neal Cardwell , Yuchung Cheng , Soheil Hassas Yeganeh , Gasper Zejn Return-path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:37047 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbeJPAYK (ORCPT ); Mon, 15 Oct 2018 20:24:10 -0400 Received: by mail-pl1-f196.google.com with SMTP id u6-v6so6831182plz.4 for ; Mon, 15 Oct 2018 09:38:11 -0700 (PDT) In-Reply-To: <20181015163758.232436-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: With the new EDT model, sch_fq no longer has to special case TCP pure acks, since their skb->tstamp will allow them being sent without pacing delay. Signed-off-by: Eric Dumazet --- net/sched/sch_fq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c index 3923d14095335df61c270f69e50cb7cbfde4c796..4b1af706896c07e5a0fe6d542dfcd530acdcf8f5 100644 --- a/net/sched/sch_fq.c +++ b/net/sched/sch_fq.c @@ -444,7 +444,7 @@ static struct sk_buff *fq_dequeue(struct Qdisc *sch) } skb = f->head; - if (skb && !skb_is_tcp_pure_ack(skb)) { + if (skb) { u64 time_next_packet = max_t(u64, ktime_to_ns(skb->tstamp), f->time_next_packet); -- 2.19.0.605.g01d371f741-goog