From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, amir@vadai.me, pshelar@ovn.org,
u9012063@gmail.com, daniel@iogearbox.net,
jakub.kicinski@netronome.com
Subject: Re: [PATCH net-next 0/3] ip_tunnel: specify tunnel type via template
Date: Tue, 16 Oct 2018 10:03:39 +0200 [thread overview]
Message-ID: <20181016080339.cq2osydjbrfbl7ja@salvia> (raw)
In-Reply-To: <20181015.214320.807689629924469586.davem@davemloft.net>
On Mon, Oct 15, 2018 at 09:43:20PM -0700, David Miller wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
> Date: Wed, 10 Oct 2018 00:24:36 +0200
>
> > The following patchset adds a new field to the tunnel metadata template.
> > This new field allows us to restrict the configuration to a given tunnel
> > driver in order to catch incorrect configuration that may result in
> > packets going to the wrong tunnel driver.
> >
> > Changes with regards to initial RFC [1] are:
> >
> > 1) Explicit tunnel type initialization to TUNNEL_TYPE_UNSPEC in existing
> > clients for this code, as requested by Daniel.
> >
> > 2) Add TUNNEL_TYPE_* definition through enum tunnel_type in
> > uapi/linux/if_tunnel.h, so we don't need to redefine this in every
> > client of this infrastructure.
> >
> > 3) Add TUNNEL_TYPE_IPIP, TUNNEL_TYPE_IPIP6 and TUNNEL_TYPE_IP6IP6, which
> > were missing in the original RFC.
> >
> > Let me know if you any more comments, thanks.
> >
> > [1] https://marc.info/?l=netfilter-devel&m=153861145204094&w=2
>
> People don't need to update a core common UAPI header to add a new
> ethernet driver.
>
> They shouldn't have to do so to add a new tunneling driver either.
>
> But that requirement is created by this patch set.
No, you can keep using TUNNEL_TYPE_UNSPEC in such scenario.
It is entirely optional and backward compatible.
prev parent reply other threads:[~2018-10-16 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 22:24 [PATCH net-next 0/3] ip_tunnel: specify tunnel type via template Pablo Neira Ayuso
2018-10-09 22:24 ` [PATCH net-next 1/3] ip_tunnel: add type field to struct ip_tunnel_info Pablo Neira Ayuso
2018-10-09 22:24 ` [PATCH net-next 2/3] net: act_tunnel_key: support for tunnel type Pablo Neira Ayuso
2018-10-09 22:24 ` [PATCH net-next 3/3] netfilter: nft_tunnel: " Pablo Neira Ayuso
2018-10-16 4:43 ` [PATCH net-next 0/3] ip_tunnel: specify tunnel type via template David Miller
2018-10-16 8:03 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016080339.cq2osydjbrfbl7ja@salvia \
--to=pablo@netfilter.org \
--cc=amir@vadai.me \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=roopa@cumulusnetworks.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).