From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net-next PATCH] net: sched: cls_flower: Classify packets using port ranges Date: Wed, 17 Oct 2018 21:42:33 -0700 (PDT) Message-ID: <20181017.214233.695288699109520404.davem@davemloft.net> References: <153935241037.11051.5334451030083154425.stgit@anamhost.jf.intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, sridhar.samudrala@intel.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: amritha.nambiar@intel.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:54356 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727469AbeJRMlh (ORCPT ); Thu, 18 Oct 2018 08:41:37 -0400 In-Reply-To: <153935241037.11051.5334451030083154425.stgit@anamhost.jf.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Amritha Nambiar Date: Fri, 12 Oct 2018 06:53:30 -0700 > Added support in tc flower for filtering based on port ranges. > This is a rework of the RFC patch at: > https://patchwork.ozlabs.org/patch/969595/ You never addressed Cong's feedback asking you to explain why this can't be simply built using existing generic filtering facilities that exist already. I appreciate that you addressed Jiri's feedback, but Cong's feedback is just as, if not more, important. Thank you.