From: David Miller <davem@davemloft.net>
To: xuechaojing@huawei.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
zhaochen6@huawei.com, tony.qu@huawei.com, yin.yinshi@huawei.com,
luoshaokai@huawei.com, fy.wang@huawei.com, luoxianjun@huawei.com
Subject: Re: [PATCH 1/1] net-next/hinic: add checksum offload and TSO support
Date: Wed, 17 Oct 2018 21:59:30 -0700 (PDT) [thread overview]
Message-ID: <20181017.215930.2300105767161105738.davem@davemloft.net> (raw)
In-Reply-To: <20181016111234.20492-1-xuechaojing@huawei.com>
From: Xue Chaojing <xuechaojing@huawei.com>
Date: Tue, 16 Oct 2018 11:12:34 +0000
> +static void get_inner_l4_info(struct sk_buff *skb, union hinic_l4 *l4,
> + enum hinic_offload_type offload_type, u8 l4_proto,
> + enum hinic_l4_offload_type *l4_offload,
> + u32 *l4_len, u32 *offset)
> +{
> + *offset = 0;
> + *l4_len = 0;
> + *l4_offload = OFFLOAD_DISABLE;
Please order local variables from longest to shortest line.
> +static int offload_csum(struct hinic_sq_task *task, u32 *queue_info,
> + struct sk_buff *skb)
> +{
> + union hinic_l3 ip;
> + union hinic_l4 l4;
> + enum hinic_l3_offload_type l3_type;
> + enum hinic_l4_offload_type l4_offload;
> + u32 offset, l4_len, network_hdr_len;
> + u8 l4_proto;
Likewise.
> @@ -184,9 +458,9 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
> unsigned int wqe_size;
> struct hinic_txq *txq;
> struct hinic_qp *qp;
> - u16 prod_idx;
> + u16 prod_idx, q_id = skb->queue_mapping;
Likewise.
prev parent reply other threads:[~2018-10-18 4:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 11:12 [PATCH 1/1] net-next/hinic: add checksum offload and TSO support Xue Chaojing
2018-10-18 4:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017.215930.2300105767161105738.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fy.wang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoshaokai@huawei.com \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=tony.qu@huawei.com \
--cc=xuechaojing@huawei.com \
--cc=yin.yinshi@huawei.com \
--cc=zhaochen6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).