From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] r8169: fix NAPI handling under high load Date: Wed, 17 Oct 2018 22:21:49 -0700 (PDT) Message-ID: <20181017.222149.1241280289340067644.davem@davemloft.net> References: <8f84fe39-3d8d-396d-3b97-027e0a83f8cb@gmail.com> <20181017233044.GA8478@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hkallweit1@gmail.com, nic_swsd@realtek.com, netdev@vger.kernel.org To: romieu@fr.zoreil.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:54878 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbeJRNVC (ORCPT ); Thu, 18 Oct 2018 09:21:02 -0400 In-Reply-To: <20181017233044.GA8478@electric-eye.fr.zoreil.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Francois Romieu Date: Thu, 18 Oct 2018 01:30:45 +0200 > Heiner Kallweit : > [...] >> This issue has been there more or less forever (at least it exists in >> 3.16 already), so I can't provide a "Fixes" tag. > > Hardly forever. It fixes da78dbff2e05630921c551dbbc70a4b7981a8fff. I don't see exactly how that can be true. That commit didn't change the parts of the NAPI poll processing which are relevant here, mainly the guarding of the RX and TX work using the status bits which are cleared. Maybe I'm missing something? If so, indeed it would be nice to add a proper Fixes: tag here. Thanks!