From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] udp6: fix encap return code for resubmitting Date: Wed, 17 Oct 2018 22:27:59 -0700 (PDT) Message-ID: <20181017.222759.2195204409874195549.davem@davemloft.net> References: <1e792b80ae514e944f868c904c30e797e02b418c.1539769397.git.pabeni@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: pabeni@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:54986 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbeJRN1N (ORCPT ); Thu, 18 Oct 2018 09:27:13 -0400 In-Reply-To: <1e792b80ae514e944f868c904c30e797e02b418c.1539769397.git.pabeni@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Paolo Abeni Date: Wed, 17 Oct 2018 11:44:04 +0200 > The commit eb63f2964dbe ("udp6: add missing checks on edumux packet > processing") used the same return code convention of the ipv4 counterpart, > but ipv6 uses the opposite one: positive values means resubmit. > > This change addresses the issue, using positive return value for > resubmitting. Also update the related comment, which was broken, too. > > Fixes: eb63f2964dbe ("udp6: add missing checks on edumux packet processing") > Signed-off-by: Paolo Abeni > --- > Note: I could not find any in kernel udp6 encap using the above > feature, that would explain why nobody complained so far... Applied.