From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: ipmr: fix unresolved entry dumps Date: Wed, 17 Oct 2018 22:36:29 -0700 (PDT) Message-ID: <20181017.223629.857704876875928943.davem@davemloft.net> References: <7e1a20a0-9ab2-5680-bde9-185c72242680@cumulusnetworks.com> <20181017193434.11383-1-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: nikolay@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:55150 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727378AbeJRNfp (ORCPT ); Thu, 18 Oct 2018 09:35:45 -0400 In-Reply-To: <20181017193434.11383-1-nikolay@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nikolay Aleksandrov Date: Wed, 17 Oct 2018 22:34:34 +0300 > If the skb space ends in an unresolved entry while dumping we'll miss > some unresolved entries. The reason is due to zeroing the entry counter > between dumping resolved and unresolved mfc entries. We should just > keep counting until the whole table is dumped and zero when we move to > the next as we have a separate table counter. > > Reported-by: Colin Ian King > Fixes: 8fb472c09b9d ("ipmr: improve hash scalability") > Signed-off-by: Nikolay Aleksandrov Applied and queued up for -stable.