From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: romieu@fr.zoreil.com, nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] r8169: fix NAPI handling under high load
Date: Wed, 17 Oct 2018 23:24:58 -0700 (PDT) [thread overview]
Message-ID: <20181017.232458.1690499475868087571.davem@davemloft.net> (raw)
In-Reply-To: <d54112bb-2f02-bd59-5b5b-e211f070b20a@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 18 Oct 2018 07:58:52 +0200
> On 18.10.2018 07:21, David Miller wrote:
>> From: Francois Romieu <romieu@fr.zoreil.com>
>> Date: Thu, 18 Oct 2018 01:30:45 +0200
>>
>>> Heiner Kallweit <hkallweit1@gmail.com> :
>>> [...]
>>>> This issue has been there more or less forever (at least it exists in
>>>> 3.16 already), so I can't provide a "Fixes" tag.
>>>
>>> Hardly forever. It fixes da78dbff2e05630921c551dbbc70a4b7981a8fff.
>>
>> I don't see exactly how that can be true.
>>
>> That commit didn't change the parts of the NAPI poll processing which
>> are relevant here, mainly the guarding of the RX and TX work using
>> the status bits which are cleared.
>>
>
> AFAICS Francois is right and patch da78dbff2e05 ("r8169: remove work
> from irq handler") introduced the guarding of RX and TX work.
> I just checked back to 3.16 as oldest LTS kernel version.
Aha, now I see it.
>> Maybe I'm missing something? If so, indeed it would be nice to add
>> a proper Fixes: tag here.
>>
> Shall I submit a v2 including the Fixes line?
Yes, please do!
prev parent reply other threads:[~2018-10-18 14:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 20:37 [PATCH net] r8169: fix NAPI handling under high load Heiner Kallweit
2018-10-16 21:17 ` Holger Hoffstätte
2018-10-16 23:03 ` Stephen Hemminger
2018-10-16 23:08 ` Florian Fainelli
2018-10-17 0:23 ` Eric Dumazet
2018-10-17 3:10 ` Florian Fainelli
2018-10-17 0:21 ` Eric Dumazet
2018-10-17 18:12 ` Heiner Kallweit
2018-10-17 18:48 ` Fwd: " Heiner Kallweit
2018-10-17 19:11 ` Holger Hoffstätte
2018-10-17 19:27 ` Heiner Kallweit
2018-10-17 20:07 ` Holger Hoffstätte
2018-10-20 9:55 ` Holger Hoffstätte
2018-10-17 23:30 ` Francois Romieu
2018-10-18 5:58 ` Jonathan Woithe
2018-10-18 6:03 ` Heiner Kallweit
2018-10-18 6:15 ` Jonathan Woithe
2018-10-18 11:52 ` Holger Hoffstätte
2018-10-19 7:29 ` Jonathan Woithe
2018-10-21 23:07 ` Jonathan Woithe
2018-10-16 22:17 ` Stephen Hemminger
2018-10-17 0:19 ` Eric Dumazet
2018-10-17 23:30 ` Francois Romieu
2018-10-18 5:21 ` David Miller
2018-10-18 5:58 ` Heiner Kallweit
2018-10-18 6:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017.232458.1690499475868087571.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).