From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] r8169: fix NAPI handling under high load Date: Wed, 17 Oct 2018 23:24:58 -0700 (PDT) Message-ID: <20181017.232458.1690499475868087571.davem@davemloft.net> References: <20181017233044.GA8478@electric-eye.fr.zoreil.com> <20181017.222149.1241280289340067644.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: romieu@fr.zoreil.com, nic_swsd@realtek.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:55612 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727357AbeJROY1 (ORCPT ); Thu, 18 Oct 2018 10:24:27 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Thu, 18 Oct 2018 07:58:52 +0200 > On 18.10.2018 07:21, David Miller wrote: >> From: Francois Romieu >> Date: Thu, 18 Oct 2018 01:30:45 +0200 >> >>> Heiner Kallweit : >>> [...] >>>> This issue has been there more or less forever (at least it exists in >>>> 3.16 already), so I can't provide a "Fixes" tag. >>> >>> Hardly forever. It fixes da78dbff2e05630921c551dbbc70a4b7981a8fff. >> >> I don't see exactly how that can be true. >> >> That commit didn't change the parts of the NAPI poll processing which >> are relevant here, mainly the guarding of the RX and TX work using >> the status bits which are cleared. >> > > AFAICS Francois is right and patch da78dbff2e05 ("r8169: remove work > from irq handler") introduced the guarding of RX and TX work. > I just checked back to 3.16 as oldest LTS kernel version. Aha, now I see it. >> Maybe I'm missing something? If so, indeed it would be nice to add >> a proper Fixes: tag here. >> > Shall I submit a v2 including the Fixes line? Yes, please do!