From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: alexei.starovoitov@gmail.com, peterz@infradead.org,
paulmck@linux.vnet.ibm.com, will.deacon@arm.com, yhs@fb.com,
john.fastabend@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next 0/3] improve and fix barriers for walking perf rb
Date: Wed, 17 Oct 2018 12:03:01 -0300 [thread overview]
Message-ID: <20181017150301.GC4041@redhat.com> (raw)
In-Reply-To: <20181017144156.16639-1-daniel@iogearbox.net>
Em Wed, Oct 17, 2018 at 04:41:53PM +0200, Daniel Borkmann escreveu:
> This set first adds smp_* barrier variants to tools infrastructure
> and in a second step updates perf and libbpf to make use of them.
> For details, please see individual patches, thanks!
>
> Arnaldo, if there are no objections, could this be routed via bpf-next
> with Acked-by's due to later dependencies in libbpf? Alternatively,
> I could also get the 2nd patch out during merge window, but perhaps
> it's okay to do in one go as there shouldn't be much conflict in perf.
Right, when updating kernel/events/ring_buffer.c the corresponding
code in tools/ should've been changed :-)
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
> Thanks!
>
> Daniel Borkmann (3):
> tools: add smp_* barrier variants to include infrastructure
> tools, perf: use smp_{rmb,mb} barriers instead of {rmb,mb}
> bpf, libbpf: use proper barriers in perf ring buffer walk
>
> tools/arch/arm64/include/asm/barrier.h | 10 ++++++++++
> tools/arch/x86/include/asm/barrier.h | 9 ++++++---
> tools/include/asm/barrier.h | 11 +++++++++++
> tools/lib/bpf/libbpf.c | 25 +++++++++++++++++++------
> tools/perf/util/mmap.h | 5 +++--
> 5 files changed, 49 insertions(+), 11 deletions(-)
>
> --
> 2.9.5
prev parent reply other threads:[~2018-10-17 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 14:41 [PATCH bpf-next 0/3] improve and fix barriers for walking perf rb Daniel Borkmann
2018-10-17 14:41 ` [PATCH bpf-next 1/3] tools: add smp_* barrier variants to include infrastructure Daniel Borkmann
2018-10-17 14:41 ` [PATCH bpf-next 2/3] tools, perf: use smp_{rmb,mb} barriers instead of {rmb,mb} Daniel Borkmann
2018-10-17 15:50 ` Peter Zijlstra
2018-10-17 23:10 ` Daniel Borkmann
2018-10-18 8:14 ` Peter Zijlstra
2018-10-18 15:04 ` Daniel Borkmann
2018-10-18 15:33 ` Alexei Starovoitov
2018-10-18 19:00 ` Daniel Borkmann
2018-10-19 3:53 ` Alexei Starovoitov
2018-10-19 11:02 ` Will Deacon
2018-10-19 11:56 ` Paul E. McKenney
2018-10-19 8:04 ` Peter Zijlstra
2018-10-19 9:44 ` Peter Zijlstra
2018-10-19 10:37 ` Daniel Borkmann
2018-10-17 14:41 ` [PATCH bpf-next 3/3] bpf, libbpf: use proper barriers in perf ring buffer walk Daniel Borkmann
2018-10-17 15:51 ` Peter Zijlstra
2018-10-17 15:03 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017150301.GC4041@redhat.com \
--to=acme@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).