From: David Miller <davem@davemloft.net>
To: natechancellor@gmail.com
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: eni: Move semicolon to a new line after empty for loop
Date: Thu, 18 Oct 2018 15:41:27 -0700 (PDT) [thread overview]
Message-ID: <20181018.154127.945780492391744369.davem@davemloft.net> (raw)
In-Reply-To: <20181017180334.8640-1-natechancellor@gmail.com>
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Wed, 17 Oct 2018 11:03:34 -0700
> Clang warns:
>
> drivers/atm/eni.c:244:48: error: for loop has empty body
> [-Werror,-Wempty-body]
> for (order = 0; (1 << order) < *size; order++);
> ^
> drivers/atm/eni.c:244:48: note: put the semicolon on a separate line to
> silence this warning
>
> In this case, that loop is expected to be empty so silence the warning
> in the way that Clang suggests.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/42
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied.
prev parent reply other threads:[~2018-10-18 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 18:03 [PATCH] atm: eni: Move semicolon to a new line after empty for loop Nathan Chancellor
2018-10-18 22:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018.154127.945780492391744369.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).