From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] atm: zatm: Fix empty body Clang warnings Date: Thu, 18 Oct 2018 15:41:33 -0700 (PDT) Message-ID: <20181018.154133.1613303373005587833.davem@davemloft.net> References: <20181017180419.8955-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: natechancellor@gmail.com Return-path: In-Reply-To: <20181017180419.8955-1-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Nathan Chancellor Date: Wed, 17 Oct 2018 11:04:19 -0700 > Clang warns: > > drivers/atm/zatm.c:513:7: error: while loop has empty body > [-Werror,-Wempty-body] > zwait; > ^ > drivers/atm/zatm.c:513:7: note: put the semicolon on a separate line to > silence this warning > > Get rid of this warning by using an empty do-while loop. While we're at > it, add parentheses to make it clear that this is a function-like macro. > > Link: https://github.com/ClangBuiltLinux/linux/issues/42 > Suggested-by: Masahiro Yamada > Signed-off-by: Nathan Chancellor Applied.