From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v4.14-stable] sch_netem: restore skb->dev after dequeuing from the rbtree Date: Thu, 18 Oct 2018 15:43:48 -0700 (PDT) Message-ID: <20181018.154348.2028947036934395230.davem@davemloft.net> References: <20181018203840.87884-1-cpaasch@apple.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, stable@vger.kernel.org, gregkh@linuxfoundation.org, stephen@networkplumber.org, edumazet@google.com, soheil@google.com, weiwan@google.com, willemb@google.com To: cpaasch@apple.com Return-path: In-Reply-To: <20181018203840.87884-1-cpaasch@apple.com> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Christoph Paasch Date: Thu, 18 Oct 2018 13:38:40 -0700 > Upstream commit bffa72cf7f9d ("net: sk_buff rbnode reorg") got > backported as commit 6b921536f170 ("net: sk_buff rbnode reorg") into the > v4.14.x-tree. > > However, the backport does not include the changes in sch_netem.c > > We need these, as otherwise the skb->dev pointer is not set when > dequeueing from the netem rbtree, resulting in a panic: ... > Fixes: 6b921536f170 ("net: sk_buff rbnode reorg") > Cc: Stephen Hemminger > Cc: Eric Dumazet > Cc: Soheil Hassas Yeganeh > Cc: Wei Wang > Cc: Willem de Bruijn > Signed-off-by: Christoph Paasch > --- > > Notes: > This patch should only make it into v4.14-stable as that's the only branch where > the offending commit has been backported to. Greg, please queue up.