From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] isdn: hfc_{pci,sx}: Avoid empty body if statements
Date: Thu, 18 Oct 2018 17:23:10 -0700 (PDT)
Message-ID: <20181018.172310.35380794084221855.davem@davemloft.net>
References: <20181018034935.16819-1-natechancellor@gmail.com>
        <20181018.154219.1246620018001438422.davem@davemloft.net>
        <20181019002117.GA10161@flashbox>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: isdn@linux-pingi.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com
To: natechancellor@gmail.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20181019002117.GA10161@flashbox>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Thu, 18 Oct 2018 17:21:17 -0700

> Thanks for the review, I went ahead and compiled with the following diff
> on top of v2 and got no warnings from Clang, GCC, or sparse, does this
> seem satisfactory for v3?

Well, one thing I notice.

> @@ -86,7 +86,7 @@ release_io_hfcpci(struct IsdnCardState *cs)
>         pci_free_consistent(cs->hw.hfcpci.dev, 0x8000,
>                             cs->hw.hfcpci.fifos, cs->hw.hfcpci.dma);
>         cs->hw.hfcpci.fifos = NULL;
> -       iounmap((void *)cs->hw.hfcpci.pci_io);
> +       iounmap(cs->hw.hfcpci.pci_io);
>  }

Driver uses iounmap().

> @@ -1692,7 +1692,7 @@ setup_hfcpci(struct IsdnCard *card)
>                 printk(KERN_WARNING "HFC-PCI: No IRQ for PCI card found\n");
>                 return (0);
>         }
> -       cs->hw.hfcpci.pci_io = (char *)(unsigned long)dev_hfcpci->resource[1].start;
> +       cs->hw.hfcpci.pci_io = (void __iomem *)(unsigned long)dev_hfcpci->resource[1].start;
>         printk(KERN_INFO "HiSax: HFC-PCI card manufacturer: %s card name: %s\n", id_list[i].vendor_name, id_list[i].card_name);

But does not use iomap().  You won't need any cast here if it did use
iomap() properly.

Thanks.