From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [net-next 03/11] igc: Add netdev
Date: Thu, 18 Oct 2018 10:15:12 -0700
Message-ID: <20181018101512.25588895@cakuba.netronome.com>
References: <20181017222322.2171-1-jeffrey.t.kirsher@intel.com>
        <20181017222322.2171-4-jeffrey.t.kirsher@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, Sasha Neftin <sasha.neftin@intel.com>,
        netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qk1-f173.google.com ([209.85.222.173]:34951 "EHLO
        mail-qk1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726463AbeJSBRM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 18 Oct 2018 21:17:12 -0400
Received: by mail-qk1-f173.google.com with SMTP id v68-v6so19250511qka.2
        for <netdev@vger.kernel.org>; Thu, 18 Oct 2018 10:15:16 -0700 (PDT)
In-Reply-To: <20181017222322.2171-4-jeffrey.t.kirsher@intel.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 17 Oct 2018 15:23:14 -0700, Jeff Kirsher wrote:
> +/**
> + * igc_ioctl - I/O control method
> + * @netdev: network interface device structure
> + * @ifreq: frequency

Is it? :)

> + * @cmd: command
> + */
> +static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
> +{
> +	switch (cmd) {
> +	default:
> +		return -EOPNOTSUPP;
> +	}
> +}

You don't seem to be adding anything to this function in the series.
Why add the stub?