From mboxrd@z Thu Jan  1 00:00:00 1970
From: LABBE Corentin <clabbe@baylibre.com>
Subject: Re: [PATCH] net: ethernet: fec: Add missing SPEED_
Date: Thu, 18 Oct 2018 20:47:15 +0200
Message-ID: <20181018184715.GA31736@Red>
References: <1539875100-11121-1-git-send-email-clabbe@baylibre.com>
 <2621cbc9-47ed-ce2a-b7ee-262f17dc138f@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: andrew@lunn.ch, davem@davemloft.net, fugang.duan@nxp.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
To: Florian Fainelli <f.fainelli@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f67.google.com ([209.85.221.67]:44856 "EHLO
        mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726325AbeJSCth (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 18 Oct 2018 22:49:37 -0400
Received: by mail-wr1-f67.google.com with SMTP id 63-v6so34766910wra.11
        for <netdev@vger.kernel.org>; Thu, 18 Oct 2018 11:47:18 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <2621cbc9-47ed-ce2a-b7ee-262f17dc138f@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Oct 18, 2018 at 11:39:24AM -0700, Florian Fainelli wrote:
> On 10/18/2018 08:05 AM, Corentin Labbe wrote:
> > Since commit 58056c1e1b0e ("net: ethernet: Use phy_set_max_speed() to limit advertised speed"), the fec driver is unable to get any link.
> > This is due to missing SPEED_.
> 
> But SPEED_1000 is defined in include/uapi/linux/ethtool.h as 1000, so
> surely this would amount to the same code paths being taken or am I
> missing something here?

The bisect session pointed your patch, reverting it fix the issue.
BUT since the fix seemed trivial I sent the patch without more test then compile it.
Sorry, I have just found some minutes ago that it didnt fix the issue.

But your patch is still the cause for sure.